1
95%
master: 95%

Ran 28 Apr 2016 07:59AM UTC

Files 210

Run time 11s

Badge

Embed ▾

Committed 28 Apr 2016 07:59AM UTC coverage: 92.401% (-0.005%) from 92.406%

Job # 1156.1

Build Type

push

travis-ci

Committed by Brian Warner

Commit Message

use twisted.web.static, not nevow.static, for public_html/

This avoids a privacy leak when the web.static= directory is configured
but doesn't exist (which is almost always, since we set `web.static =
public_html` in the default config file, but nothing automatically
creates it). The nevow.static.File class tries to os.stat() the
directory before doing anything else, which causes an exception, which
renders the traceback to the HTTP client as a 500 Internal Server Error,
and the traceback includes the full path of the missing public_html
directory, which reveals the node's basedir.

Plain twisted.web.static.File doesn't do this check, and a missing
web.static directory just results in a plain old 404.

Closes ticket:1720.

Run Details

50452 of 54601 relevant lines covered (92.4%)

0.92 hits per line

tahoe-lafs / tahoe-lafs / 1156 / 1
95%
master: 95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1156.1

tahoe-lafs / tahoe-lafs / 1156 / 1 95% master: 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1156.1

tahoe-lafs / tahoe-lafs / 1156 / 1
95%
master: 95%

README BADGES
x