3
78%
master: 79%

Ran 03 Apr 2024 02:06AM UTC

Files 259

Run time 12s

Badge

Embed ▾

Committed 03 Apr 2024 02:02AM UTC coverage: 68.53% (+0.03%) from 68.502%

Job # 8532137691.3

Build Type

push

github

Committed by

jrfnl

Commit Message

File::getMethodProperties(): skip over closure use statements

This PR improves performance of the `File::getMethodProperties()` method and prevents incorrect return type information for closures `use` clauses containing invalid variable imports in the `use` clause (defensive coding).

Closure `use` statements can only import plain variables, not properties or other more complex variables.

As things were, when such "illegal" variables were imported in a closure `use`, the information for the return type could get mangled.
While this would be a parse error, for the purposes of static analysis, the `File::getMethodProperties()` method should still handle this correctly.

This commit updates the `File::getMethodProperties()` method to always skip over the complete `use` clause, which prevents the issue and improves performance as the same time (less token walking).

Includes unit tests.

Run Details

16554 of 24156 relevant lines covered (68.53%)

18.54 hits per line

PHPCSStandards / PHP_CodeSniffer / 8532137691 / 3
78%
master: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job php-7.2-custom-ini-false - 8532137691.3

PHPCSStandards / PHP_CodeSniffer / 8532137691 / 3 78% master: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job php-7.2-custom-ini-false - 8532137691.3

PHPCSStandards / PHP_CodeSniffer / 8532137691 / 3
78%
master: 79%

README BADGES
x