3
79%
master: 85%

Ran 24 Apr 2016 11:17PM UTC

Files 104

Run time 5s

Badge

Embed ▾

Committed 24 Apr 2016 11:08PM UTC coverage: 78.413%. First build

Job # AUTOTOOLS=no COVERAGE=yes BUILD=static

Build Type

push

travis-ci

Committed by

mgreter

Commit Message

Fix issue when using intermediate string returns

In MSVC the following can lead to segfault:
sass_copy_c_string(stream.str().c_str());
Reason is that the string returned by str() is disposed before
sass_copy_c_string is invoked. The string is actually a stack
object, so indeed nobody is holding on to it. So it seems
perfectly fair to release it right away. So the const char*
by c_str will point to invalid memory. I'm not sure if this is
the behavior for all compiler, but I'm pretty sure we would
have gotten more issues reported if that would be the case.
Wrapping it in a functions seems the cleanest approach as the
function must hold on to the stack variable until it's done.

Run Details

8896 of 11345 relevant lines covered (78.41%)

433685.41 hits per line

mgreter / libsass / 2075 / 3
79%
master: 85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2075.3 (AUTOTOOLS=no COVERAGE=yes BUILD=static)

mgreter / libsass / 2075 / 3 79% master: 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2075.3 (AUTOTOOLS=no COVERAGE=yes BUILD=static)

mgreter / libsass / 2075 / 3
79%
master: 85%

README BADGES
x