1
37%
master: 45%

Ran 13 Mar 2024 10:05PM UTC

Files 21

Run time 0s

Badge

Embed ▾

Committed 13 Mar 2024 10:02PM UTC coverage: 36.648% (-0.008%) from 36.656%

Job # 8272149761.1

Build Type

Pull #185

github

Committed by

maaslalani

Commit Message

feat(textinput): do not block input on validation

This PR builds upon the excellent work in #167 and #114 and makes a
breaking change to the validation API.

Currently, validation will completely block text input if the Validate
function returns an error. This is now changed so the function no longer
blocks input if this is the case, thus handing this responsibility to
the clients.

This is helpful for cases where the user is requested to type an
existing system path, and the Validate function keeps asserting the
existence of the path. With the current implementation such a validation
is not possible.

For example:

    > /
    Err: nil

    > /t
    Err: /t: No such file or directory

    > /tm
    Err: /tm: No such file or directory

    > /tmp
    Err: nil

Pull Request Pull Request #185: feat(textinput): do not block input on validation

Run Details

1537 of 4194 relevant lines covered (36.65%)

60.15 hits per line

charmbracelet / bubbles / 8272149761 / 1
37%
master: 45%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 8272149761.1

charmbracelet / bubbles / 8272149761 / 1 37% master: 45%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 8272149761.1

charmbracelet / bubbles / 8272149761 / 1
37%
master: 45%

README BADGES
x