1
62%
development: 62%

Ran 26 Feb 2024 02:44PM UTC

Files 722

Run time 25s

Badge

Embed ▾

Committed 26 Feb 2024 08:53AM UTC coverage: 76.019% (-0.5%) from 76.478%

Job # 8046097519.1

Build Type

push

github

Committed by

web-flow

Commit Message

fix: avoid cloning range proofs during verification (#6166)

Description
---
Removes unnecessary cloning of range proofs during batch verification.

Motivation and Context
---
Currently, range proofs exist in transaction outputs as byte vectors.
When parsing outputs to collect these proofs for batch verification, the
byte vectors are cloned. This is done because the verification API
requires that the vector of proofs contain a vector reference to each
proof, but the `BulletRangeProof` type wrapper provides a slice instead
as part of its `ByteArray` implementation. Because proofs are several
hundred bytes and batches can be large, this cloning is wasteful.

This PR adds `BulletRangeProof::as_vec`, which returns the underlying
range proof as a vector reference. Doing so lets us avoid the clone
while collecting the range proofs.

How Has This Been Tested?
---
Existing tests pass.

What process can a PR reviewer use to test or verify this change?
---
Confirm that the change removes the cloning.

Coverage Stats

74876 of 98497 relevant lines covered (76.02%)

240452.53 hits per line

tari-project / tari / 8046097519 / 1
62%
development: 62%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 8046097519.1

tari-project / tari / 8046097519 / 1 62% development: 62%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 8046097519.1

tari-project / tari / 8046097519 / 1
62%
development: 62%

README BADGES
x