1
62%
master: 62%

Ran 15 Apr 2016 03:17AM UTC

Files 450

Run time 12s

Badge

Embed ▾

Committed 15 Apr 2016 02:47AM UTC coverage: 69.035% (-0.4%) from 69.423%

Job # 639.1

Build Type

push

travis-ci

Committed by Commit bot

Commit Message

tsmon: Stop linking "goconvey" and "testing" into real production executables.

Attempting to use tsmon library in an executable that uses "flag.Parse()"
reveals that "goconvey" and "testing" register all their flags there, suggesting
that some testing init() code executes somewhere and register all these flags:

$ ./luci_machine_tokend
-pkey-pem is required
Usage of ./luci_machine_tokend:
  ...
  -convey-json
      When true, emits results in JSON blocks. Default: 'false'
  -convey-silent
      When true, all output from GoConvey is suppressed.
  ....
  -test.bench string
      regular expression to select benchmarks to run
  -test.benchmem
      print memory allocations for benchmarks
  ...

Move store/testing.go into its own package, and do a bit of duck typing to avoid
module import cycle (storetest package tests interface that quack similarly
enough to store.Store).

Remove ModifyMulti since it wasn't used and it references real Modification
struct that's non-importable from storetest. If it is ever needed, Modification
should be moved to its own small package, importable from both tsmon/store and
tsmon/store/storetest.

R=dsansome@chromium.org, nodir@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1889693004

Coverage Stats

24910 of 36083 relevant lines covered (69.04%)

2123.0 hits per line

luci / luci-go / 639 / 1
62%
master: 62%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 639.1

luci / luci-go / 639 / 1 62% master: 62%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 639.1

luci / luci-go / 639 / 1
62%
master: 62%

README BADGES
x