• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Ouranosinc / xscen / 7818947441 / 3
90%
main: 90%

Build:
DEFAULT BRANCH: main
Ran 07 Feb 2024 05:47PM UTC
Files 19
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

07 Feb 2024 05:43PM UTC coverage: 65.367% (-0.07%) from 65.439%
7818947441.3

push

github

web-flow
Make xESMF optional (#337)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes hydrologie/xhydro#81
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] (If applicable) Tests have been updated.
- [x] This PR does not seem to break the templates.
- [x] CHANGES.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?

* Make xesmf optional:
+ Remove it from the dependencies in "pyproject.toml". It is now an
"extra" dependency. I did not remove it from the environment.yml files
as the issue doesn't occur with conda.
+ Add a few "try: import" throughout the package and raise on call time
when xesmf is not available.
    + Skip the tests that require xesmf, if not present.
+ Edit the tox config to remove any usage of conda, since it is now not
needed.

### Does this PR introduce a breaking change?
No.

### Other information:
@Zeitsperre I may have been heavy handed in editing the workflow and tox
configuration. My idea was that the "test-pypi" didn't need xesmf/esmf
anymore and so I removed any mention of it and of mamba/conda. So it can
really be a "test-pypi" ci.

We accept the decrease in coveralls for the Pypi tests, it is a consequence of removing xesmf.

2599 of 3976 relevant lines covered (65.37%)

0.65 hits per line

Source Files on job run-Python3.11-conda - 7818947441.3
  • Tree
  • List 0
  • Changed 2
  • Source Changed 0
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 7818947441
  • a40422a2 on github
  • Prev Job for on main (#7818127197.3)
  • Next Job for on main (#7878114567.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc