4
98%
main: 98%

Ran 14 Apr 2016 04:12AM UTC

Files 10

Run time 0s

Badge

Embed ▾

Committed 14 Apr 2016 04:10AM UTC coverage: 99.457%. First build

Job # ruby-head, ACTION_MAILER_VERSION=4

Build Type

Pull #157

travis-ci

Committed by

woahdae

Commit Message

Fix loading protocol-relative URLs over a network

Previously, protocol-relative URLs such as "//www.example.com/foo.css"
would throw an error when loaded. This is due to a subtle issue with
URI parsing in the stardard library, bordering on a bug, where URI()
would appear to parse something like "http:////www.example.com" in a
sane manner, but actually would not set URI#hostname, and potentially
other methods, nor would it pass equality (`==`) with
"http://www.example.com"

This fixes the issue by building the URI more manually. Note, in Ruby
2.3 we could have used URI::join, but this particular case fails in Ruby
2.1 using URI::join.

Pull Request Pull Request #157: Fix loading protocol-relative URLs over a network

Coverage Stats

183 of 184 relevant lines covered (99.46%)

5.01 hits per line

fphilipe / premailer-rails / 163 / 4
98%
main: 98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 163.4 (ruby-head, ACTION_MAILER_VERSION=4)

fphilipe / premailer-rails / 163 / 4 98% main: 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 163.4 (ruby-head, ACTION_MAILER_VERSION=4)

fphilipe / premailer-rails / 163 / 4
98%
main: 98%

README BADGES
x