2
78%
master: 79%

Ran 31 Jan 2024 08:29PM UTC

Files 258

Run time 8s

Badge

Embed ▾

Committed 31 Jan 2024 08:24PM UTC coverage: 68.176%. First build

Job # 7731966781.2

Build Type

push

github

Committed by

jrfnl

Commit Message

Generic/LowerCaseType: bug fix in intersection type ignore code

PR squizlabs/PHP_CodeSniffer 3581 introduced support for PHP 8.1 intersection types.
_Note: the sniff, or PHPCS itself for that matter, currently does not (yet) support PHP 8.2 DNF types. Once support for DNF types has been added, this sniff will need a further update/fix.

For now, for the purpose of this sniff, intersection types should be skipped as they cannot contain the simple types for which the case is being checked by this sniff.

However, the check for whether a type is an intersection type or not was wrong.
The `'*type_token'` key for each of these checks contains the stack pointer to the _first_ token in the type declaration, so the comparison with `T_TYPE_INTERSECTION` will always yield `false`.

This did not lead to false positives due to how the type is handled after that, but is still a bug which should be fixed.

Run Details

16356 of 23991 relevant lines covered (68.18%)

16.22 hits per line

PHPCSStandards / PHP_CodeSniffer / 7731966781 / 2
78%
master: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job php-7.2-custom-ini-false - 7731966781.2

PHPCSStandards / PHP_CodeSniffer / 7731966781 / 2 78% master: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job php-7.2-custom-ini-false - 7731966781.2

PHPCSStandards / PHP_CodeSniffer / 7731966781 / 2
78%
master: 79%

README BADGES
x