bitcoindevkit / bdk / 7729885809 / 1

84%

master: 84%

push

github

Merge bitcoindevkit/bdk#1186: Clean up clippy allows

<a class=hub.com/bitcoindevkit/bdk/commit/1c15cb2f9169bb08a4128c183eeeca80fff97ab7">1c15cb2f9<a href="https://github.com/bitcoindevkit/bdk/commit/c6b9ed3b766e20ce34a6a09854784a4a9081cd37"> ref(example_cli): Add new struct Init (vmammal)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/89a7ddca7f6ed8c65ed0124774f3a868d08faf68">89a7ddca7</a><a href="https://github.com/bitcoindevkit/bdk/commit/c6b9ed3b766e20ce34a6a09854784a4a9081cd37"> ref(esplora): `Box` a large `esplora_client::Error` (vmammal)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/097d818d4c7fff12d72ce0ef10ceb9b575c154e1">097d818d4</a><a href="https://github.com/bitcoindevkit/bdk/commit/c6b9ed3b766e20ce34a6a09854784a4a9081cd37"> ref(wallet): `Wallet::preselect_utxos` now accepts a `&amp;TxParams` (vmammal)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/f11d663b7efb98dd72fed903ade8c5e7af0b5a3a">f11d663b7</a><a href="https://github.com/bitcoindevkit/bdk/commit/c6b9ed3b766e20ce34a6a09854784a4a9081cd37"> ref(psbt): refactor body of `get_utxo_for` to address `clippy::manual_map` (vmammal)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/4679ca1df7209d2b356fbb8cbd675f07756d1301">4679ca1df</a><a href="https://github.com/bitcoindevkit/bdk/commit/c6b9ed3b766e20ce34a6a09854784a4a9081cd37"> ref(example_cli): add typedefs to reduce type complexity (vmammal)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/64a90192d9d49c3df22d2b5f489ba20222fd941a">64a90192d</a> refactor: remove old clippy allow attributes (vmammal)

Pull request description:

  closes #1127

  There are several instances in the code where we allow clippy lints that would otherwise be flagged during regular checks. It would be preferable to minimize the number of "clippy allow" attributes either by fixing the affected areas or setting a specific configuration in `clippy.toml`. In cases where we have to allow a particular lint, it should be documented why the lint doesn't apply.

  For context see https://github.com/bitcoindevkit/bdk/issues/1127#issuecomment-1784256647 as well as the commit message details.

  One area I'm unsure of is whether `Box`ing a large error in 4fc2216 is the right approach. Logically it makes sense to avoid allocating a needlessly heavy `Result`, but I haven't studied the implications or tradeoffs of such a change.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  evanlinjin:
    ACK 1c15cb2f9169bb08a4128c183eeeca80fff97ab7

Tree-SHA512: 5fa3796a3b00dce0946f4cd88d5d8c94d85

9222 of 11376 relevant lines covered (81.07%)

5699.06 hits per line