• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

PulpQE / pulp-smash / 429 / 1
63%
master: 63%

Build:
DEFAULT BRANCH: master
Ran 12 Apr 2016 05:42PM UTC
Files 6
Run time 0s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

12 Apr 2016 05:00PM UTC coverage: 74.458%. Remained the same
429.1

push

travis-ci

Ichimonji10
Deduplicate test skipping logic

A given Pulp server may have an arbitrary set of plugins installed.
Consequently, not all tests in Pulp Smash apply to a given Pulp server.
Pulp Smash chooses which tests to run by executing a `setUpModule`
function in each `test*` module, and this function talks to the Pulp
server and checks to see if the relevant plugin is installed.

This works, but it's not DRY. Every single `test*` module must define a
nearly identical function, and each of these functions contains a magic
keyword like "docker_image" or "rpm". Address this by defining one
`set_up_module` function in each of the following:

* pulp_smash.tests.docker.utils
* pulp_smash.tests.ostree.utils
* pulp_smash.tests.puppet.utils
* pulp_smash.tests.rpm.utils

Then, `import set_up_module as setUpModule` as needed. This change does
not change test results. Test results gathered with the following
commands:

    nose pulp_smash.tests
    nose2 pulp_smash.tests
    py.test --pyargs pulp_smash.tests
    python -m unittest2 discover pulp_smash.tests

(Note that nose treats `SkipTest` exceptions as errors.)

Related to https://github.com/PulpQE/pulp-smash/issues/182.

309 of 415 relevant lines covered (74.46%)

0.74 hits per line

Source Files on job 429.1
  • Tree
  • List 0
  • Changed 0
  • Source Changed 0
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 429
  • Travis Job 429.1
  • be81eda9 on github
  • Prev Job for on master (#427.1)
  • Next Job for on master (#431.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc