zopefoundation / Zope / 7519001499 / 1

82%

master: 82%

push

github

Fix redirections to URLS with host given as IP-litteral (#1192)

When redirecting to an URL with an IPv6 host with surrounding brackets,
we should not escape the surrounding brackets.

The patch updates referenced RFC from 2396 to 3986, which obsoletes it
and change the safe characters for the netloc part to allow [ and ].
The RFC specifies that [ and ] are only allowed when they are the first
and last characters, but we don't need to be more specific here, because
using [ or ] in other places of the host is rejected by urlparse above.

Fixes #1191

4367 of 6981 branches covered (0.0%)

Branch coverage included in aggregate %.

27581 of 31890 relevant lines covered (86.49%)

0.86 hits per line