1
88%
main: 88%

Ran 10 Jan 2024 03:42AM UTC

Files 991

Run time 20s

Badge

Embed ▾

Committed 10 Jan 2024 02:28AM UTC coverage: 87.549% (-0.02%) from 87.573%

Job # 7469929160.1

Build Type

push

github

Committed by

web-flow

Commit Message

Fix quadratic construction time of `QuantumCircuit` (#11517)

* Fix quadratic construction time of `QuantumCircuit`

The current implementation of `CircuitData.add_qubit` (ditto `clbit`)
has linear time complexity because it reconstructs the list on each
addition, while the `CircuitData.qubits` getter silently clones the
list on return.  This was intended to avoid inadvertant Python-space
modifications from getting the Rust components out of sync, but in
practice, this cost being hidden in a standard attribute access makes it
very easy to introduce accidental quadratic dependencies.

In this case, `QuantumCircuit(num_qubits)` and subsequent
`qc.append(..., qc.qubits)` calls were accidentally quadratic in
`num_qubits` due to repeated accesses of `QuantumCircuit.qubits`.

* Restore explicit Python token

* Strengthen warnings

Run Details

59802 of 68307 relevant lines covered (87.55%)

202966.11 hits per line

Qiskit / qiskit / 7469929160 / 1
88%
main: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 7469929160.1

Qiskit / qiskit / 7469929160 / 1 88% main: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 7469929160.1

Qiskit / qiskit / 7469929160 / 1
88%
main: 88%

README BADGES
x