3
63%
master: 63%

Ran 17 Dec 2023 06:13AM UTC

Files 79

Run time 1s

Badge

Embed ▾

Committed 17 Dec 2023 06:07AM UTC coverage: 59.171% (+0.02%) from 59.155%

Job # 6591302788186112.3

Build Type

push

CirrusCI

Committed by

SomberNight

Commit Message

plugins: follow-up prev, log thread name when loading plugins

Correction to comment in prev commit (and removing it here):
spec.loader.exec_module does not spawn new threads, it simply
executes the module in the current thread.
I got confused but turns out "load_plugin" itself is sometimes
not called from the main thread. Specifically (e.g.), since the recent
wizard rewrite, in the qt gui, the wizard loads the hww plugins
from a new thread.

This now better explains the macos hww crashes: they had started
appearing because we upgraded hidapi (which made it more sensitive
to having to import from main thread) AND scanning(->importing) from
the wizard no longer happened on the main thread after the rewrite.

Plugins should be thread-safe in terms of where they are imported from.
Let's log the importer thread's name (added here), to help recognise
related threading issues.

Run Details

18982 of 32080 relevant lines covered (59.17%)

0.59 hits per line

spesmilo / electrum / 6591302788186112 / 3
63%
master: 63%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6591302788186112.3

spesmilo / electrum / 6591302788186112 / 3 63% master: 63%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6591302788186112.3

spesmilo / electrum / 6591302788186112 / 3
63%
master: 63%

README BADGES
x