1
91%
main: 91%

Ran 05 Dec 2023 06:12PM UTC

Files 14

Run time 0s

Badge

Embed ▾

Committed 05 Dec 2023 06:11PM UTC coverage: 92.607% (+0.2%) from 92.448%

Job # 123.1

Build Type

push

github

Committed by

web-flow

Commit Message

fix: don't crash if `none` is a supported request signing alg (#297)

* fix: don't crash if `none` is a supported request signing alg

Instead, catch the error and allow the upstream to fall back to a
different approach. For the `oidcc_authorization` module, that means
normal query parameters rather than a signed request object.

In particular, I ran into this when calling `create_redirect_url` with a
client ID and client secret (not `:unauthenticated`) when `none` is a
supported request signing alg.

This might be eliminating support for `none` signed request JWTs
entirely, but it wasn't clear whether that's required for clients.

* fix: support `none` signing if `unsecured_signing` is true

Run Details

714 of 771 relevant lines covered (92.61%)

172.5 hits per line

erlef / oidcc / 123 / 1
91%
main: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 123.1

erlef / oidcc / 123 / 1 91% main: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 123.1

erlef / oidcc / 123 / 1
91%
main: 91%

README BADGES
x