vbuch / node-signpdf / 6971743894 / 2 – placeholder-pdfkit010

100%

master: 100%

push

github

:bug: Signer.sign() is an async method so the typing should indicate it can be a promise

At the moment the typings are wrong because the sign function is reported to be `sign(pdfBuffer: Buffer) => Buffer`.
However, this is not a correct typing as the method is expected to return a promise as it is `async`. The sign method
can also return a Buffer (sync) as is done in the P12Signer. Therefore the typings should be
`sign(pdfBuffer: Buffer) => Promise<Buffer> | Buffer`.

12 of 13 branches covered (0.0%)

Branch coverage included in aggregate %.

35 of 36 relevant lines covered (97.22%)

3.56 hits per line