couchbase
/
moss
/
33
/
1
83%
master: 83%
master: 83%
|
Ran
|
Files
8
|
Run time
3min
|
Badge
Embed ▾
README BADGES
|
coverage: 83.93% (-8.3%) from 92.202%
push
travis-ci
steveyenMB-18594 - use cond Broadcast() instead of Signal() Along the way to diagnosing MB-18594, I saw hundreds of moss related goroutines in some dump-of-goroutines output, where merger and persister goroutines from multiple moss collections where waiting for work to do. Perhaps they weren't getting closed/stopped correctly? This made me take a look at the the condition variable usage in moss, so this fix is related to invoking cond.Broadcast() instead of cond.Signal(), in order to notify all cond var waiters, not just a single waiter. This might not actually fix the "hundreds of goroutines" situation, but I believe is more theoretically correct. Change-Id: I59cd545ca Reviewed-on: http://review.couchbase.org/62121 Reviewed-by: Marty Schoch <marty.schoch@gmail.com> Tested-by: Steve Yen <steve.yen@gmail.com>
1008 of 1201 relevant lines covered (83.93%)
1717.46 hits per line
Source Files on job 33.1
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
|---|