1
87%
main: 87%

Ran 10 Oct 2023 05:03PM UTC

Files 1265

Run time 28s

Badge

Embed ▾

Committed 10 Oct 2023 04:29PM UTC coverage: 87.006% (-0.02%) from 87.024%

Job # 6472153023.1

Build Type

push

github

Committed by

web-flow

Commit Message

Fix hash of `Parameter` and `ParameterExpression` (#10875)

* Fix hash of `Parameter` and `ParameterExpression`

This fixes the construction paths for `Parameter` and its hash such that
it will now correctly hash equal to any `ParameterExpression`s that it
compares equal to.  This is a requirement of the Python data model for
hashmaps and hashsets, which previously we were breaking.  In order to
achieve this, we slightly modify the hash key such that the `Parameter`
instances are no longer a part of the hash of `ParameterExpression`,
which means we can use the same hashing strategy for both.

This rearrangement has the benefit of removing the requirement for the
`__new__` overrides on `Parameter` and `ParameterVectorElement`.

* Add type hint

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Tweak documentation wording

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

Coverage Stats

74142 of 85215 relevant lines covered (87.01%)

90905.75 hits per line

Qiskit / qiskit / 6472153023 / 1
87%
main: 87%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6472153023.1

Qiskit / qiskit / 6472153023 / 1 87% main: 87%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6472153023.1

Qiskit / qiskit / 6472153023 / 1
87%
main: 87%

README BADGES
x