1
95%
main: 95%

Ran 03 Oct 2023 01:28AM UTC

Files 40

Run time 3s

Badge

Embed ▾

Committed 03 Oct 2023 12:56AM UTC coverage: 89.291% (+0.001%) from 89.29%

Job # 6387273103.1

Build Type

push

github

Committed by

thibaultcha

Commit Message

fix(proxy-wasm) do not accidentally reset filter list from FFI call

When calling `proxy_wasm.set_property` from Lua, we want a `pwctx`
to be able to store a property. But we need to do that before
`proxy_wasm.start`, so `pwctx->ready` didn't have a chance to get
initialized yet.

Passing `NULL, 0` to `filter_ids` and `nfilters` when obtaining the `pwctx`
from the `set_property` FFI call caused the `pwctx` to get initialized with an
empty filter list, defeating the configuration previously set up by
`proxy_wasm.attach`.

In this fix, we make the `NULL` value of `filter_ids` to mean
"please don't do the `pwctx->ready` initialization". The other
use of `ngx_proxy_wasm_ctx` in `ngx_wasm_ops.c` always passes a
non-NULL value (even when the filter list is empty), because the
`elts` pointer is allocated on `ngx_array_init`.

This issue caused an integration failure in Kong Gateway. This PR
includes a regression test for our test suite, which reproduces the
sequence observed in the Gateway; the test fails without the fix
added to `ngx_proxy_wasm.c` and passes with the fix.

Run Details

6137 of 6873 relevant lines covered (89.29%)

1781.13 hits per line

Kong / ngx_wasm_module / 6387273103 / 1
95%
main: 95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job unit-ngx_1.25.2-wasmer-no_ssl-no_debug-no_hup-static - 6387273103.1

Kong / ngx_wasm_module / 6387273103 / 1 95% main: 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job unit-ngx_1.25.2-wasmer-no_ssl-no_debug-no_hup-static - 6387273103.1

Kong / ngx_wasm_module / 6387273103 / 1
95%
main: 95%

README BADGES
x