1
84%
main: 88%

Ran 01 Oct 2023 09:55AM UTC

Files 6

Run time 0s

Badge

Embed ▾

Committed 01 Oct 2023 09:53AM UTC coverage: 83.844% (-0.1%) from 83.982%

Job # 6369713012.1

Build Type

Pull #110

github

Committed by

nunnatsa

Commit Message

New Rule: should not compare two different types

The `Equal` and the `BeIdentical` matchers also check the type, not only
the value.

The following code will fail in runtime:
```go
x := 5 // x is int
Expect(x).Should(Eqaul(uint(5)) // x and uint(5) are with different
types
```

When using negative checks, it's even worse, because we get a fale
positive:
```
x := 5
Expect(x).ToNot(Equal(uint(5))
```

To solve this problem, we want to find these errors before running the
tests and failing on runtime. This is even more important for e2e or
functional tests, where we sometimes can't run them on the local
development environment.

This PR adds a new rule to the linter, to find comaprison of values
from different types.

Pull Request Pull Request #110: New Rule: should not compare two different types

Run Details

986 of 1176 relevant lines covered (83.84%)

807.32 hits per line

nunnatsa / ginkgolinter / 6369713012 / 1
84%
main: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6369713012.1

nunnatsa / ginkgolinter / 6369713012 / 1 84% main: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6369713012.1

nunnatsa / ginkgolinter / 6369713012 / 1
84%
main: 88%

README BADGES
x