|
Ran
|
Files
369
|
Run time
12s
|
Badge
README BADGES
|
push
github
Fix check to _not_ run npm snapshot when on Version Packages PRs (#724) ## Summary: We've had an ongoing issue where the changeset action that produces a snapshot npm version for PRs also runs on the `Version Packages` PR, but fails. This is because our check for changesets finds none on those PRs. In these special `Version Packages` PRs, the changeset tool does all the work needed to get the affected packages ready for release and deletes all the changeset files. This PR fixes the issue. We (Juan, Marian, and I) [suspect](https://khanacademy.slack.com/archives/C4PE1QM5Y/p1694626375783619?thread_ts=1694619602.325429&cid=C4PE1QM5Y) that the `base_ref` is not the correct Github context variable to reference and instead are switching to use `head_ref` (which is already [in use](https://github.com/Khan/wonder-blocks/blob/fe03ac160/.github/workflows/chromatic-pr.yml#L10-L11) and seems to work properly in the Wonder Blocks repository) Issue: LC-1091 ## Test plan: Do a release and make sure that Github doesn't try to run the npm snapshot step for the Version Packages PR. Author: jeremywiebe Reviewers: jeremywiebe, jandrade, nedredmond, SonicScrewdriver, handeyeco, marianmwang Required Reviewers: Approved By: nedredmond, jandrade Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ gerald Pull Request URL: https://github.com/Khan/perseus/pull/724
1884 of 9646 branches covered (0.0%)
Branch coverage included in aggregate %.
5535 of 18759 relevant lines covered (29.51%)
928.28 hits per line
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line | Branch Hits | Branch Misses |
|---|