• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Khan / perseus / 6176248780 / 1 – cypress
69%
main: 69%

Build:
DEFAULT BRANCH: main
Ran 13 Sep 2023 06:22PM UTC
Files 369
Run time 12s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

13 Sep 2023 06:11PM UTC coverage: 26.119%. Remained the same
cypress – 6176248780.1

push

github

web-flow
Fix check to _not_ run npm snapshot when on Version Packages PRs (#724)

## Summary:

We've had an ongoing issue where the changeset action that produces a snapshot npm version for PRs also runs on the `Version Packages` PR, but fails. This is because our check for changesets finds none on those PRs. In these special `Version Packages` PRs, the changeset tool does all the work needed to get the affected packages ready for release and deletes all the changeset files. 

This PR fixes the issue. We (Juan, Marian, and I) [suspect](https://khanacademy.slack.com/archives/C4PE1QM5Y/p1694626375783619?thread_ts=1694619602.325429&cid=C4PE1QM5Y) that the `base_ref` is not the correct Github context variable to reference and instead are switching to use `head_ref` (which is already [in use](https://github.com/Khan/wonder-blocks/blob/fe03ac160/.github/workflows/chromatic-pr.yml#L10-L11) and seems to work properly in the Wonder Blocks repository)

Issue: LC-1091

## Test plan:

Do a release and make sure that Github doesn't try to run the npm snapshot step for the Version Packages PR.

Author: jeremywiebe

Reviewers: jeremywiebe, jandrade, nedredmond, SonicScrewdriver, handeyeco, marianmwang

Required Reviewers:

Approved By: nedredmond, jandrade

Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ gerald

Pull Request URL: https://github.com/Khan/perseus/pull/724

1884 of 9646 branches covered (0.0%)

Branch coverage included in aggregate %.

5535 of 18759 relevant lines covered (29.51%)

928.28 hits per line

Source Files on job cypress - 6176248780.1
  • Tree
  • List 0
  • Changed 16
  • Source Changed 0
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Build 6176248780
  • ab69a2e9 on github
  • Prev Job for on main (#6173657813.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc