1
94%
master: 94%

Ran 16 Mar 2016 08:29PM UTC

Files 40

Run time 19min

Badge

Embed ▾

Committed 16 Mar 2016 08:20PM UTC coverage: 83.95%. Remained the same

Job # USE_CLANG_COMPLETER=true YCMD_PYTHON_VERSION=2.7 COVERAGE=true

Build Type

push

travis-ci

Committed by

homu

Commit Message

Auto merge of #433 - micbou:include-order, r=Valloric

[READY] Include headers from external projects last

Currently, headers are included by CMake in this order (when compiling with Clang support):
 - BoostParts
 - Python
 - Clang
 - `cpp\ycm`
 - `cpp\ycm\ClangCompleter`

The issue with this order is that if one of our headers has the same name as one of BoostParts, Python, or Clang headers, the wrong header may be included (depending on how it is included in the code). It can't happen with GCC and Clang compilers because the `-isystem` flag is used for these includes (`-isystem` directories are searched after `-I` directories). However, it is possible on Windows since there is no `-isystem` equivalent for MSVC. See issue in PR #291 where Python `token.h` is included instead of ycmd `Token.h`.

We prevent this by including the Boost, Python, and Clang directories after the ycmd ones.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/433)
<!-- Reviewable:end -->

Run Details

2950 of 3514 relevant lines covered (83.95%)

0.84 hits per line

Valloric / ycmd / 1765 / 1
94%
master: 94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1765.1 (USE_CLANG_COMPLETER=true YCMD_PYTHON_VERSION=2.7 COVERAGE=true)

Valloric / ycmd / 1765 / 1 94% master: 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1765.1 (USE_CLANG_COMPLETER=true YCMD_PYTHON_VERSION=2.7 COVERAGE=true)

Valloric / ycmd / 1765 / 1
94%
master: 94%

README BADGES
x