1
40%
master: %

Ran 13 Mar 2016 02:54PM UTC

Files 26

Run time 0s

Badge

Embed ▾

Committed 13 Mar 2016 02:40PM UTC coverage: 35.438% (+0.04%) from 35.397%

Job # BOX_LOCAL_NAME=foxbox BOX_PORT=3000

Build Type

push

travis-ci

Committed by

Yoric

Commit Message

Propagated upstream changes: Adapter API now uses transformable_channels instead of raw callbacks.

The use of raw callbacks caused us to fire two threads for watching
the clock *per watch* and it looked like other adapters, which need to
deal with even more complex inputs, would be at least as bad. There
was no way we could have sustained this number of threads in actual
use. Using channels proved to have the exact same issue.

I have written a small crate transformable_channels that extends
channels with `map`, `filter`, `filter_map`, which removes the need
for all these phony threads. Crates foxbox_taxonomy and
foxbox_adapters have been ported to use transformable_channels. This
patch propagates the changes downstream.

By porting to transformable_channels, I have successfully removed the
threads-per-watch. High-level client code is now once again in charge
of deciding when and where to use threads.

For a complete discussion on raw callbacks vs. Sender<>
vs. transformable_channels, and a Pre-RFC on transformable_channels,
see
https://internals.rust-lang.org/t/pre-rfc-transformations-on-channels/

Run Details

696 of 1964 relevant lines covered (35.44%)

0.7 hits per line

fxbox / foxbox / 687 / 1
40%
master: %

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 687.1 (BOX_LOCAL_NAME=foxbox BOX_PORT=3000)

fxbox / foxbox / 687 / 1 40% master: %

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 687.1 (BOX_LOCAL_NAME=foxbox BOX_PORT=3000)

fxbox / foxbox / 687 / 1
40%
master: %

README BADGES
x