Khan / perseus / 5956285679 / 2 – jest

69%

main: 69%

push

github

Convert all JSX.LibraryManagedAttributes to use PropsFor<> (#691)

## Summary:

Previously in Flow we had a simple type for exatracting prop types of a component while reatining their optionality: `React.ElementConfig<typeof MyComponent>`. In TypeScript the equivalent is alot uglier:

```javascript 
JSX.LibraryManagedAttributes<
   typeof MyComponent,
   React.ComponentProps<typeof MyComponent>
>
```

Wonder Stuff Core recently added a helper named `PropsFor<>` that works like Flow's `ElmeentConfig<T>` and so this PR adapts to use that new type.

One related fix I made was to remove the `context` object from the `Renderer`'s constructor. That's a deprecated pattern in React and I couldn't find any usages that do that. 

Issue: "none"

## Test plan:

`yarn typecheck`
`yarn test` (just to be safe)

Author: jeremywiebe

Reviewers: somewhatabstract, #perseus

Required Reviewers:

Approved By: somewhatabstract

Checks: ✅ finish_coverage, ✅ gerald, ⏭  Publish npm snapshot, ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ gerald

Pull Request URL: https://github.com/Khan/perseus/pull/691

5754 of 7024 branches covered (81.92%)

Branch coverage included in aggregate %.

70158 of 112919 relevant lines covered (62.13%)

458.51 hits per line