1
92%
master: 91%

Ran 18 Aug 2023 08:06PM UTC

Files 16

Run time 1s

Badge

Embed ▾

Committed 18 Aug 2023 08:04PM UTC coverage: 91.437% (-0.05%) from 91.491%

Job # 5906639669.1

Build Type

push

github

Committed by

lkiesow

Commit Message

Fix configuration without authentication

If an empty password was configured in the user interface configuration,
instead of requiring no authentication, pyCA would throw an internal
server error:

```
Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/flask/app.py", line 2528, in wsgi_app
    response = self.full_dispatch_request()
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/flask/app.py", line 1825, in full_dispatch_request
    rv = self.handle_user_exception(e)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/flask/app.py", line 1823, in full_dispatch_request
    rv = self.dispatch_request()
         ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/flask/app.py", line 1799, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/lars/dev/opencast/pyCA/pyca/ui/utils.py", line 16, in decorated
    or auth.username != config('ui', 'username') \
       ^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'username'
```

This patch fixes the issue.

Run Details

961 of 1051 relevant lines covered (91.44%)

0.91 hits per line

opencast / pyCA / 5906639669 / 1
92%
master: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5906639669.1

opencast / pyCA / 5906639669 / 1 92% master: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5906639669.1

opencast / pyCA / 5906639669 / 1
92%
master: 91%

README BADGES
x