microsoft / botbuilder-js / 5892509380 / 2

84%

main: 84%

push

github

fix: Upgrading restify to fix error on Node version 18+ (#4515)

Current version leads to the following error on Node 18+:

➜  my-echo-bot npm start

> my-echo-bot@1.0.0 start
> node ./index.js

/home/gregborrelly/development/myJsBots/my-echo-bot/node_modules/restify/lib/request.js:848
    Request.prototype.closed = function closed() {
                             ^

TypeError: Cannot set property closed of #<Readable> which has only a getter
    at patch (/home/gregborrelly/development/myJsBots/my-echo-bot/node_modules/restify/lib/request.js:848:30)
    at Object.<anonymous> (/home/gregborrelly/development/myJsBots/my-echo-bot/node_modules/restify/lib/server.js:33:1)

9910 of 12925 branches covered (76.67%)

Branch coverage included in aggregate %.

20133 of 22485 relevant lines covered (89.54%)

3817.15 hits per line