2
98%
master: 99%

Ran 24 Feb 2014 04:21AM UTC

Files 25

Run time –

Badge

Embed ▾

Committed 24 Feb 2014 04:14AM UTC coverage: 97.528%. First build

Job # 2.1.0

Build Type

push

travis-ci

Committed by

trotzig

Commit Message

Only scroll when necessary on keyboard navigation

This commit replaces the previous usage of the native JS function
`scrollIntoView` with a jQuery solution instead. The new solution:

- Only scrolls when the focused element is hidden.
- Keeps 1/4 of the screen above the focused element (for context).
- Animates the scroll (this improved the experience by *a lot*, because
  you can see exactly what happens)

To figure out if an element is shown on the screen or not, I'm using the
`jquery.visible` Bower plugin. I tried out a couple of alternatives that
did scrolling, but both `jquery.scrollIntoView` (buggy) and
`jquery.scrollTo` (didn't avoid scrolling if it wasn't needed) came in
short.

An important detail about the animation: The previous animation is
cancelled (`stop()`ed) before the next is started. This is important in
order to allow people hammering/holding down j/k.

Run Details

434 of 445 relevant lines covered (97.53%)

26.24 hits per line

trotzig / diffux / 202 / 2
98%
master: 99%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 202.2 (2.1.0)

trotzig / diffux / 202 / 2 98% master: 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 202.2 (2.1.0)

trotzig / diffux / 202 / 2
98%
master: 99%

README BADGES
x