1
81%
dev: 88%

Ran 29 Feb 2016 09:29PM UTC

Files 40

Run time 3min

Badge

Embed ▾

Committed 29 Feb 2016 09:24PM UTC coverage: 81.045% (-0.1%) from 81.151%

Job # 1080.1

Build Type

push

travis-ci

Committed by

prashantv

Commit Message

Fix bug causing TestCloseSingleChannel to fail

There was a very subtle bug when a connection is closed right after a
successful call is received.
recvPeerFrame was blocked in select {recvCh, errCh}. When a connection
reads a frame, puts it into the recvCh, but then gets an EOF and puts
an EOF error in the errCh, the select will randomly choose a case.
There is no priority order.

In our case, we want a strict priority order when reading frames to
always choose recvCh if there's any frames, and process errors after.
Emulate a priority order by checking recvCh in the errCh case using
a non-blocking select (both on the writer and reader side).

Run Details

3040 of 3751 relevant lines covered (81.05%)

1717.64 hits per line

uber / tchannel-go / 1080 / 1
81%
dev: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1080.1

uber / tchannel-go / 1080 / 1 81% dev: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1080.1

uber / tchannel-go / 1080 / 1
81%
dev: 88%

README BADGES
x