• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

jlfwong / speedscope / 5276572457 / 3
44%
master: 47%

Build:
Build:
LAST BUILD BRANCH: jlfwong/copy-summary-text
DEFAULT BRANCH: master
Ran 15 Jun 2023 08:32AM UTC
Files 83
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

15 Jun 2023 08:32AM UTC coverage: 42.16% (+0.05%) from 42.108%
5276572457.3

push

github

web-flow
Use `frame.name?.startsWith` for stackprof (#419)

Sometimes, stackprof frames don't get generated with a `name` in the frame.
I think it's probably worth tracking down why that is, but in the mean
time, speedscope simply crashes with a method call on `undefined`. The
crash is bad because it only shows up in the console--there's no visible
message saying that speedscope failed to parse and load a profile.

For more information, see #378

This fixes the crash by simply skipping the logic in demangle if the name
field isn't present on a frame. That's probably a fine tradeoff? Because in
this case, stackprof is generating ruby frames, which means that C++ name
demangling won't apply.

I have tested this by running the scripts/prepare-test-installation.sh
script and verifying that `bin/cli.js` can now successfully load the
included profile. Before these changes, I verified that speedscope failed
with the behavior mentioned in #378.

I've also included a snapshot test case, but it seems that the Jest test
harness only tests the parsing, not the rendering (correct me if I'm wrong).
So I haven't actually been able to create an automated test that would catch
a regression. Please let me know if there's a better way to have written this
test.

I've staged the commits on this branch so that the second commit (dcb9840)
showcases the minimal diff to a stackprof file that reproduces the bug. That is,
rather than look at the thousands of new lines in the stackprof profile, you can
view the second commit to see the salient part of the file.

1100 of 2709 branches covered (40.61%)

Branch coverage included in aggregate %.

2535 of 5913 relevant lines covered (42.87%)

2145.97 hits per line

Source Files on job run-12.x - 5276572457.3
  • Tree
  • List 0
  • Changed 13
  • Source Changed 0
  • Coverage Changed 13
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Build 5276572457
  • e9133be3 on github
  • Prev Job for on main (#5276415483.3)
  • Next Job for on main (#5339511205.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc