1
95%
main: 95%

Ran 10 Jun 2023 08:19PM UTC

Files 41

Run time 3s

Badge

Embed ▾

Committed 10 Jun 2023 07:51PM UTC coverage: 88.273% (+0.03%) from 88.245%

Job # 5231662144.1

Build Type

push

github

Committed by

thibaultcha

Commit Message

fix(proxy-wasm) handle internal redirects with and without filter chains

During internal redirects Nginx clears the request context which in our
case holds `rctx`. Leveraged by Kong Gateway to handle a category of
HTTP errors, reproduced in LuaJIT FFI tests.

The `r->pool` cleanup will be invoked for any number of attached
`rctxs`, which in the case of internal redirects can be more than one
(since auto-created by `ngx_http_wasm_ctx`). In this case, `r` contains
the newer `rctx`, which is then used in both handlers and causes a
use-after-free (or free-after-free attempt).

Instead, we do not override this function's `rctx` variable since it was
already given via `data`, which in this branch comes from the pool
cleanup trigger, and will be distinct for each pool cleanup handler run.
Multiple `rctxs` can be cleaned up when their associated `r->pool` is
freed. This also correctly frees both filter chains (attached to each
`rctx`).

Coverage Stats

5894 of 6677 relevant lines covered (88.27%)

1689.33 hits per line

Kong / ngx_wasm_module / 5231662144 / 1
95%
main: 95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job unit-ngx_1.25.0-wasmer-no_ssl-no_debug-no_hup - 5231662144.1

Kong / ngx_wasm_module / 5231662144 / 1 95% main: 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job unit-ngx_1.25.0-wasmer-no_ssl-no_debug-no_hup - 5231662144.1

Kong / ngx_wasm_module / 5231662144 / 1
95%
main: 95%

README BADGES
x