1
96%
master: 96%

Ran 23 Feb 2016 06:38PM UTC

Files 90

Run time 3s

Badge

Embed ▾

Committed 23 Feb 2016 06:39PM UTC coverage: 96.328%. Remained the same

Job # 1.9.3

Build Type

push

travis-ci

Committed by

lencioni

Commit Message

Handle files that begin with comments in PrivateNamingConvention

After trying out this new rule, I noticed a couple of bugs. Both are
related, and one caused a crash. They both happen when the file begins
with a comment.

For some reason, if the file starts with a comment, the engine seems to
visit the function usage twice, once before it visits the function
definition, and once after. Since we are relying on the order that these
things are visited here, this causes a lint to happen.

But even worse, when visiting a variable within a for loop, the node has
no source range, which causes a crash. This only seems to happen when
the file begins with a comment.

I fixed these by making sure that things have a source range before we
determine their position, and by also checking the top level even though
we really shouldn't need to.

Coverage Stats

2676 of 2778 relevant lines covered (96.33%)

365.02 hits per line

sds / scss-lint / 1181 / 1
96%
master: 96%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1181.1 (1.9.3)

sds / scss-lint / 1181 / 1 96% master: 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1181.1 (1.9.3)

sds / scss-lint / 1181 / 1
96%
master: 96%

README BADGES
x