3
63%
master: 63%

Ran 27 Jan 2016 07:13PM UTC

Files 6

Run time 0s

Badge

Embed ▾

Committed 27 Jan 2016 07:13PM UTC coverage: 75.429%. Remained the same

Job # 201.3

Build Type

push

travis-ci

Committed by

Ichimonji10

Commit Message

Improve CLI transport detection logic

The CLI client, `pulp_smash.cli.Client`, can execute commands either locally or
remotely over SSH. A user can explicitly choose which transport to use by
setting the `cli_transport` setting on a server config object:

    >>> from pulp_smash import cli, config
    >>> cfg = ServerConfig('pulp.example.com', cli_transport='local')
    >>> client = cli.Client(cfg)

Alternately, a user may omit the `cli_transport` option and let Pulp Smash guess
what to do. Pulp Smash will choose to execute commands locally if the hostname
of the current system (the one running Pulp Smash) matches the hostname given to
the server config object. Pulp Smash will choose to execute commands over SSH
otherwise.

Pulp Smash currently fetches the hostname of the current system using the
`socket.gethostname()` function. This isn't an ideal choice: it sometimes
returns an abbreviated hostname, instead of a fully-qualified domain name. Fix
this. Make Pulp Smash use the `socket.getfqdn()` function, which more
aggressively attempts to return a fully qualified domain name.

Test suite results do not change as a result of this commit.

Run Details

264 of 350 relevant lines covered (75.43%)

0.75 hits per line

PulpQE / pulp-smash / 201 / 3
63%
master: 63%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 201.3

PulpQE / pulp-smash / 201 / 3 63% master: 63%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 201.3

PulpQE / pulp-smash / 201 / 3
63%
master: 63%

README BADGES
x