1
70%
master: 97%

Ran 26 Jan 2016 08:20AM UTC

Files 96

Run time 3s

Badge

Embed ▾

Committed 26 Jan 2016 08:20AM UTC coverage: 70.289% (-0.3%) from 70.57%

Job # 9907.1

Build Type

push

travis-ci

Committed by

robertknight

Commit Message

Prevent double-posting of new annotations

When the user clicks the 'Post' button to create an annotation,
optimistically switch the card back to View mode but display
a 'Saving...' indicator in place of the Reply/Edit/Delete links.

This makes the UI appear more responsive when the user clicks
the Post button and also prevents an issue where the user could
click 'Post' multiple times during the save and create multiple
annotations.

 * Fix a possible inconsistency between the 'Post' button's enabled
   state and whether or not the save() function can succeed.

   The hasContent() and isShared() methods also already have tests,
   so this lets us remove several redundant tests.

 * Fix inconsistency in the return type of the save() function -
   always return a promise.

 * Treat negative status values as network errors as well as 0.
   If the server is unreachable, the real status value may be -1.

Fixes #2864

Run Details

2678 of 3810 relevant lines covered (70.29%)

0.7 hits per line

hypothesis / h / 9907 / 1
70%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 9907.1

hypothesis / h / 9907 / 1 70% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 9907.1

hypothesis / h / 9907 / 1
70%
master: 97%

README BADGES
x