mozilla-releng / balrog / #3378 / 1

90%

main: 90%

Pull #2802

circleci

Fix logging call in rulematching

When enabling debug logging we can end up with:

balrogpub_1    | --- Logging error ---
balrogpub_1    | Traceback (most recent call last):
balrogpub_1    |   File "/usr/local/lib/python3.9/logging/__init__.py", line 434, in format
balrogpub_1    |     return self._format(record)
balrogpub_1    |   File "/usr/local/lib/python3.9/logging/__init__.py", line 430, in _format
balrogpub_1    |     return self._fmt % record.__dict__
balrogpub_1    | KeyError: 'requestid'
balrogpub_1    |
balrogpub_1    | During handling of the above exception, another exception occurred:
balrogpub_1    |
balrogpub_1    | Traceback (most recent call last):
balrogpub_1    |   File "/usr/local/lib/python3.9/logging/__init__.py", line 1083, in emit
balrogpub_1    |     msg = self.format(record)
balrogpub_1    |   File "/usr/local/lib/python3.9/logging/__init__.py", line 927, in format
balrogpub_1    |     return fmt.format(record)
balrogpub_1    |   File "/usr/local/lib/python3.9/logging/__init__.py", line 666, in format
balrogpub_1    |     s = self.formatMessage(record)
balrogpub_1    |   File "/usr/local/lib/python3.9/logging/__init__.py", line 635, in formatMessage
balrogpub_1    |     return self._style.format(record)
balrogpub_1    |   File "/usr/local/lib/python3.9/logging/__init__.py", line 436, in format
balrogpub_1    |     raise ValueError('Formatting field not found in record: %s' % e)
balrogpub_1    | ValueError: Formatting field not found in record: 'requestid'
balrogpub_1    | Call stack:
balrogpub_1    |   File "/usr/local/lib/python3.9/site-packages/flask/app.py", line 2548, in __call__
balrogpub_1    |     return self.wsgi_app(environ, start_response)
balrogpub_1    |   File "/usr/local/lib/python3.9/site-packages/flask/app.py", line 2525, in wsgi_app
balrogpub_1    |     response = self.full_dispatch_request()
balrogpub_1    |   File "/usr/local/lib/python3.9/site-packages/flask/app.py", line 1820, in full_dispatch_request
bal... (continued)

2588 of 2999 branches covered (86.3%)

Branch coverage included in aggregate %.

5831 of 6374 relevant lines covered (91.48%)

0.91 hits per line