1
100%
master: 100%

Ran 21 Aug 2022 09:55PM UTC

Files 77

Run time 2s

Badge

Embed ▾

Committed 21 Aug 2022 09:55PM UTC coverage: 98.366% (+0.03%) from 98.338%

Job # #3255.1

Build Type

push

github-actions

Committed by

ben-manes

Commit Message

Fix weak/soft computeIfAbsent when a value is published but expiry fails

If a computeIfAbsent discovers that the value was reference collected then
it performs the eviction and reuses that entry with the new value. If the
expiry calculation fails (as user code), then the computation is rolled
back. Previously the setting order allowed the new value to be exposed
early so it remained in the cache.

The entry's metadata should be calculated, the value set, and then the
metadata. This way calculations do not leave remnants and an expired
value is not read as valid. A stricter memory ordering is required to
ensure that this is not reordered by the compiler/hardware in case of a
injected data store (e.g. safepoint), rather than piggybacking on the
lock release. While not observed, as x86 is TSO, this avoids a possible
race on a weaker memory model (arm64).

Coverage Stats

7343 of 7465 relevant lines covered (98.37%)

0.98 hits per line

ben-manes / caffeine / #3255 / 1
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job #3255.1

ben-manes / caffeine / #3255 / 1 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job #3255.1

ben-manes / caffeine / #3255 / 1
100%
master: 100%

README BADGES
x