5
77%
master: 77%

Ran 14 Jun 2022 06:10AM UTC

Files 58

Run time 19s

Badge

Committed 14 Jun 2022 06:05AM UTC coverage: 73.968% (-0.1%) from 74.1%

Job # CONF_OPTIONS="--enable-gcov --enable-single-obj-compilation --enable-cplusplus --disable-shared --enable-gc-assertions" CFLAGS_EXTRA="-D USE_CUSTOM_SPECIFIC" CC_FOR_CHECK=g++ MAKEFILE_TARGETS="all" MAKEFILE_TARGETS_CHECK="check" NO_CLONE_LIBATOMIC_OPS=true REPORT_COVERAGE=true TESTS_CUSTOM_RUN=true

Build Type

push

travis-ci-com

Committed by

ivmai

Commit Message

Fix race between calloc_explicitly_typed/push_complex_descriptor with lock
(fix of commits 4e020ef3c, 1e6c80be3)

Issue #449 (bdwgc).

Hold the allocation lock while writing a complex descriptor to the
object to ensure that the descriptor is seen by GC_array_mark_proc
as expected.

It should be possible to avoid locking by using the atomic operations
(with the release barrier in GC_calloc_explicitly_typed) but this
would need the acquire barrier in GC_array_mark_proc and its callee
(doing without the acquire barrier is tricky as GC_mark_some might be
invoked with the world running).

* typd_mlc.c [AO_HAVE_store] (GC_calloc_explicitly_typed): Do not use
AO_store operations.
* typd_mlc.c (GC_calloc_explicitly_typed): Remove volatile for lp
local variable; add comment; replace set_obj_descr() calls with direct
write to ((word*)op)[nwords-1]; wrap write to *lp and writing to
((word*)op)[nwords-1] into LOCK/UNLOCK.
* typd_mlc.c (get_complex_descr): Remove TODO item (but not
GC_ATTR_NO_SANITIZE_THREAD attribute).

Coverage Stats

7365 of 9957 relevant lines covered (73.97%)

8576162.39 hits per line

Source Files on job 1326.5 (CONF_OPTIONS="--enable-gcov --enable-single-obj-compilation --enable-cplusplus --disable-shared --enable-gc-assertions" CFLAGS_EXTRA="-D USE_CUSTOM_SPECIFIC" CC_FOR_CHECK=g++ MAKEFILE_TARGETS="all" MAKEFILE_TARGETS_CHECK="check" NO_CLONE_LIBATOMIC_OPS=true REPORT_COVERAGE=true TESTS_CUSTOM_RUN=true)

ivmai / bdwgc / 1326 / 5
77%
master: 77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

ivmai / bdwgc / 1326 / 5 77% master: 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

ivmai / bdwgc / 1326 / 5
77%
master: 77%

README BADGES
x