3
100%
stable: 100%

Ran 30 Nov 2015 12:18AM UTC

Files 74

Run time 2s

Badge

Embed ▾

Committed 30 Nov 2015 - 0:18 coverage: 99.389%. Remained the same

Job # 280.3

Build Type

push

travis-ci

Committed by

sirosen

Commit Message

Refactored action verification to be multi-phase

The structure of "verify_can_exec" being invoked as part of execute() was a
little funky, and it required that each action type do the same dance at the
beginning of execution. True, this is slated for removal, but that is a long
term goal, and in the meantime this has grown into a bit of a mess. Instead,
differentiates __call__() from execute() on actions by having __call__() do
verification before execution. Additionally, breaks down verification into two
steps: get a code (which tells us not only if we can proceed, but why or why
not), and then translate that code to a True/False value to tell us whether or
not to proceed. Without this breakdown, the 'OK' code has to act somewhat
truthy, which is not necessarily correct if we want other codes to allow
execution. For example, a "target exists" code could be fine for copy actions,
but still allows for more informative messaging than a raw "OK".

Run Details

1301 of 1309 relevant lines covered (99.39%)

0.99 hits per line

Source Files on job 280.3

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

sirosen / SALVE / 280 / 3
100%
stable: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 280.3

sirosen / SALVE / 280 / 3 100% stable: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 280.3

sirosen / SALVE / 280 / 3
100%
stable: 100%

README BADGES
x