Coveralls logob
Coveralls logo
  • Home
  • Features
  • Pricing
  • Docs
  • Sign In

sirosen / SALVE / 280 / 2
Job Ran: 30 Nov 2015 12:18AM UTC (2.2s)
100%
stable: 100%

DEFAULT BRANCH: stable
Build:
LAST BUILD BRANCH: wip/refactor/2-3-0-cleanup
Repo Added 24 Jul 2014 04:56AM UTC
# Builds 228 Last
Badge
Badge Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

30 Nov 2015 - 0:18 coverage remained the same at 99.694%
280

push

travis-ci

Cdc8ae0deeff355ccfd6dab8a9ed8623?size=18&default=identiconsirosen
Refactored action verification to be multi-phase

The structure of "verify_can_exec" being invoked as part of execute() was a
little funky, and it required that each action type do the same dance at the
beginning of execution. True, this is slated for removal, but that is a long
term goal, and in the meantime this has grown into a bit of a mess. Instead,
differentiates __call__() from execute() on actions by having __call__() do
verification before execution. Additionally, breaks down verification into two
steps: get a code (which tells us not only if we can proceed, but why or why
not), and then translate that code to a True/False value to tell us whether or
not to proceed. Without this breakdown, the 'OK' code has to act somewhat
truthy, which is not necessarily correct if we want other codes to allow
execution. For example, a "target exists" code could be fine for copy actions,
but still allows for more informative messaging than a raw "OK".

1305 of 1309 relevant lines covered (99.69%)

7.96 hits per line

Source Files on job 280.2
  • List 74
  • Changed 0
  • Source Changed 0
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 280
  • Travis Job 280.2
  • 62ab8870 on github
  • Prev Job for on wip/refactor/general-cleanup (#279.2)
  • Next Job for on wip/refactor/general-cleanup (#281.2)
Troubleshooting · Open an Issue · Sales · Support · ENTERPRISE · CAREERS · STATUS
BLOG · TWITTER · Legal & Privacy · Supported CI Services · What's a CI service? · Automated Testing

© 2022 Coveralls, Inc