zopefoundation / BTrees

94%

master: 94%

LAST BUILD ON BRANCH remove-byvalue-except-ii-226

branch: remove-byvalue-except-ii-226

CHANGE BRANCH

x

Reset

• remove-byvalue-except-ii-226
• 4.10.0
• 4.10.1
• 4.11.1
• 4.11.2
• 4.11.3
• 4.5.1
• 4.6.0
• 4.6.1
• 4.7.0
• 4.7.1
• 4.7.2
• 5.0
• 5.1
• 5.2
• 6.0
• 6.1
• 6.2
• 6.4
• GHA
• all-repos_autofix_all-repos-sed
• cleaner-releases
• config-with-c-code
• config-with-c-code-template-1351c95d
• config-with-c-code-template-1c89c2aa
• config-with-c-code-template-21b3fb2e
• config-with-c-code-template-24cb1653
• config-with-c-code-template-27ca14d4
• config-with-c-code-template-2dc0cedb
• config-with-c-code-template-3c1c588c
• config-with-c-code-template-42457e0c
• config-with-c-code-template-4dc0484e
• config-with-c-code-template-8d837c89
• config-with-c-code-template-9e2b2911
• config-with-c-code-template-a17d8c29
• config-with-c-code-template-a361e1fd
• config-with-c-code-template-a7193216
• config-with-c-code-template-b21fbbf2
• config-with-c-code-template-e45966cd
• config-with-c-code-template-f472bcc5
• coverage
• create-4.5.0-wheels
• dont-break-math
• drop-py313
• drop-py34
• drop-setup-requires
• fix-GHA-pypy2-py310-macos
• fix-appveyor-build
• fix-macos-wheel-upload
• fix_py_persistency#118
• isort
• issue120
• issue121
• issue131
• issue132
• issue137
• issue138
• issue140
• issue153
• issue155
• issue156
• issue161
• issue166
• issue168
• issue170
• issue171
• issue24
• issue94
• issue96
• issue98
• mac-os-py311
• master
• py37_build
• py38
• reduce-boilerplate
• restructure-travis
• segfault-on-unicode
• travis_3.8
• tseaver-207-move_static_globals_to_module_state
• tseaver-drop_setup_py_test_fossils
• tseaver-lint_squish
• tseaver-pep489
• tseaver-scrub_compat_fossils
• update-manylinux
• use-pypi-token

Build # 31156006456

Build Type

Pull #229

github

Committed by icemac

Commit Message

Remove byValue() except from the II and LL families (#226)

byValue() could crash the interpreter for families with object values: a
value whose comparison method mutated the bucket freed the array the C code
was iterating over.

Rather than hardening that code, remove the long deprecated method
everywhere except the II and LL families, which are the modules reachable as
family32.II and family64.II -- the only ones known to be used (by
Products.ZCatalog.Catalog.search) and immune to the crash, since their
values are C integers whose comparison never runs Python code.

The declaration moves from IDictionaryIsh to the new IByValue interface.

The surviving pure-Python implementation now matches the C one: it
normalizes the values by dividing them by min before sorting and returns a
list.

Pull Request Pull Request #229: Remove byValue() except from the II and LL families (#226)

Coverage Stats

643 of 675 branches covered (95.26%)

Branch coverage included in aggregate %.

83 of 86 new or added lines in 4 files covered. (96.51%)

7724 of 8235 relevant lines covered (93.79%)

6.56 hits per line