zopefoundation / BTrees / 31156006456

94%

master: 94%

Pull #229

github

Remove byValue() except from the II and LL families (#226)

byValue() could crash the interpreter for families with object values: a
value whose comparison method mutated the bucket freed the array the C code
was iterating over.

Rather than hardening that code, remove the long deprecated method
everywhere except the II and LL families, which are the modules reachable as
family32.II and family64.II -- the only ones known to be used (by
Products.ZCatalog.Catalog.search) and immune to the crash, since their
values are C integers whose comparison never runs Python code.

The declaration moves from IDictionaryIsh to the new IByValue interface.

The surviving pure-Python implementation now matches the C one: it
normalizes the values by dividing them by min before sorting and returns a
list.

643 of 675 branches covered (95.26%)

Branch coverage included in aggregate %.

83 of 86 new or added lines in 4 files covered. (96.51%)

7724 of 8235 relevant lines covered (93.79%)

6.56 hits per line