zodb / relstorage

96%

master: 92%

LAST BUILD ON BRANCH cache-file-temp-better

branch: cache-file-temp-better

CHANGE BRANCH

x

Reset

• cache-file-temp-better
• 1.6
• 1.6-no-zeo
• 1.6.1
• 1.6.2
• 1.6.3
• 2.0.0
• 2.0.0b4
• 2.0.0b5
• 2.0.0b6
• 2.0.0b7
• 2.0.0b8
• 2.0.0b9
• 2.0.0rc1
• 2.1.0
• 2.1.1
• 2.1a1
• 2.1a2
• 3.0.0
• 3.0.1
• 3.0a10
• 3.0a11
• 3.0a12
• 3.0a13
• 3.0a2
• 3.0a3
• 3.0a4
• 3.0a5
• 3.0a6
• 3.0a7
• 3.0a9
• 3.0b1
• 3.0b2
• 3.0b3
• 3.0rc1
• 3.1.0
• 3.1.1
• 3.1.2
• 3.2.0
• 3.2.1
• 3.5.0
• 3.6
• 4.0.0
• 4.0.0a1
• 4.1.0
• 4.1.1
• ZODB5-before-instance-optimization
• afterCompletion
• appveyor
• appveyor38
• argparse
• better-cache-validation
• better-lock-algorithm
• better_store_conn_cleanup
• bigger_MVCC_depth_by_default
• blobhelper-never-none
• boost1_83-gcc13
• boost_1_75
• btrees472
• cache-read-opts
• check-cache-for-readCurrent
• ci-for-pr-20
• cleanup-blob-tests
• commit-lock-ex
• configure-sqlite
• conflict-res-from-cache
• coveralls-ignore-oracle
• cython-3rc2
• default-postgres-version
• faster-cache-validation
• faster-conflict-loading
• faster-pack
• faster-pg-gevent
• faster-vacuum
• file-time-tid
• find_packages
• finer-lru
• fix-135-16
• fix-135-master
• gcc13-py12-updates
• generic-txncontrol
• github-actions
• issue125
• issue159
• issue166
• issue169
• issue173
• issue175
• issue178
• issue181
• issue186
• issue188
• issue201
• issue206
• issue210
• issue211
• issue212
• issue212-mysql
• issue213
• issue216
• issue218
• issue220
• issue222
• issue224
• issue227
• issue228
• issue232
• issue239
• issue241
• issue242
• issue246
• issue247
• issue249
• issue264
• issue266
• issue270
• issue280
• issue281
• issue281-pg
• issue283
• issue291
• issue293
• issue296
• issue302
• issue304
• issue310
• issue311
• issue311-take2
• issue317
• issue325
• issue329
• issue339
• issue340
• issue342
• issue344
• issue376
• issue381
• issue389
• issue401
• issue403
• issue407
• issue409
• issue411
• issue421
• issue424
• issue425
• issue438
• issue446
• issue454
• issue460
• issue464
• issue468
• issue474
• issue511
• issue78
• issue9
• issuo61
• jim-test
• jim-zodb5
• legacy-zodb-removal
• lint
• llbtree-delta
• loadBefore-optimization
• log-improvements
• mamico-1.6-travis
• master
• monkey-zodb-139
• more-logging
• more-merging
• more-tests-16
• mvcc-logging
• mysql-connector
• mysql-myisasm
• mysql-set-min-oid
• mysql-tid-rounding
• native-updated-pypy
• new-protocol
• no-close-conn-vote-conflict
• none_bucket_on_load
• old-pypy
• oracle-fixes
• pcache-correct-tids
• pcache-missed-update
• pers-cache
• persistent-cache-efficiency
• pg-row-batcher-arrays
• pg_faster_lock_and_move
• poll-old-cache
• poller_no_if
• postgresql-lockless-commit
• prep-statements
• prep30a9
• py-updates
• py312
• py36
• py39
• reduce-cache-locking
• refactor-dbs
• refactor-save
• refactor-simple-service
• revert-lock-order
• rst-files
• simplify-max-stored
• simplify-tracing
• smaller-include
• sqlite-gevent
• sqlite-optimize
• sqlite-stats
• storage-is-not-threadsafe
• transaction2.0
• travis37
• umysqldb
• unify-oids
• unreleased-updates
• update-mysqlconnector
• update-zodb
• use-unsigned-tree
• w-tinylru
• w-tinylru-cffi
• wheels-on-travis
• zodb522-blobs
• zodbconvert-improvements

Build # 506

Build Type

push

travis-ci

Committed by jamadden

Commit Message

Extra safety writing temporary cache files.

Take more care with exception handling and being extra sure to clean up
temporary files.

Refactor to make this more obvious.

In addition, don't open files unless we're going to read them, not just
to stat them. This may open some small race conditions, but we should be
robust to them. It makes it more likely that this process will work on
Windows. It does use more system calls, but this shouldn't be a
bottleneck for reasonably sized cache directories.

Let the system generate cache file names for us, and replace old files
instead of renaming on top of them. This should be less racy overall.

Run Details

59 of 59 new or added lines in 1 file covered. (100.0%)

5055 of 5279 relevant lines covered (95.76%)

7.81 hits per line