• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

zalando-incubator / stackset-controller
73%
master: 50%

Build:
Build:
LAST BUILD BRANCH: refs/tags/v1.4.118
DEFAULT BRANCH: master
Repo Added 26 Sep 2018 01:23PM UTC
Files 44
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH type-label
branch: type-label
CHANGE BRANCH
x
Reset
  • type-label
  • add-flag
  • add-rps-type
  • alpine-3
  • autoscaler/hpa-min-replicas-from-stack
  • autoscaling-v2
  • basic-code
  • better-detection
  • bump-copyrights-year
  • cleanup
  • config-map-e2e
  • config-rsc-e2e
  • configmap-and-secret-refs
  • configmap-inline-another-try
  • configmap-per-stack
  • configmap-per-stack-v1
  • configuration-resources-simpler-tests
  • configuration-resources-tests
  • controller-tools-v0.14.0
  • convert-hollow-stacksets
  • crd-stack-ingressrg
  • custom-configmap-refs
  • dependabot/go_modules/all-go-mod-patch-and-minor-032054ca12
  • dependabot/go_modules/all-go-mod-patch-and-minor-08bab2d290
  • dependabot/go_modules/all-go-mod-patch-and-minor-125e26e7d0
  • dependabot/go_modules/all-go-mod-patch-and-minor-19159fc169
  • dependabot/go_modules/all-go-mod-patch-and-minor-1cb18fde37
  • dependabot/go_modules/all-go-mod-patch-and-minor-1d0099a666
  • dependabot/go_modules/all-go-mod-patch-and-minor-1f6149a51d
  • dependabot/go_modules/all-go-mod-patch-and-minor-214b2fb350
  • dependabot/go_modules/all-go-mod-patch-and-minor-23aa00a82f
  • dependabot/go_modules/all-go-mod-patch-and-minor-2537eb30c6
  • dependabot/go_modules/all-go-mod-patch-and-minor-26c1dae6df
  • dependabot/go_modules/all-go-mod-patch-and-minor-2e4a9bc555
  • dependabot/go_modules/all-go-mod-patch-and-minor-2e53f835cf
  • dependabot/go_modules/all-go-mod-patch-and-minor-329abb2d95
  • dependabot/go_modules/all-go-mod-patch-and-minor-3aa13dbe9f
  • dependabot/go_modules/all-go-mod-patch-and-minor-63d1a8e96c
  • dependabot/go_modules/all-go-mod-patch-and-minor-68e354fce4
  • dependabot/go_modules/all-go-mod-patch-and-minor-6b9fc38362
  • dependabot/go_modules/all-go-mod-patch-and-minor-6ee8def3e0
  • dependabot/go_modules/all-go-mod-patch-and-minor-763c885c2f
  • dependabot/go_modules/all-go-mod-patch-and-minor-76bf7f19ac
  • dependabot/go_modules/all-go-mod-patch-and-minor-79ad0d4c43
  • dependabot/go_modules/all-go-mod-patch-and-minor-7fc3cae053
  • dependabot/go_modules/all-go-mod-patch-and-minor-80329b2d23
  • dependabot/go_modules/all-go-mod-patch-and-minor-80fcc7cd98
  • dependabot/go_modules/all-go-mod-patch-and-minor-862f04464c
  • dependabot/go_modules/all-go-mod-patch-and-minor-91ea8dc060
  • dependabot/go_modules/all-go-mod-patch-and-minor-92a7691f83
  • dependabot/go_modules/all-go-mod-patch-and-minor-94b2979147
  • dependabot/go_modules/all-go-mod-patch-and-minor-95c97d8fd8
  • dependabot/go_modules/all-go-mod-patch-and-minor-966837bfa0
  • dependabot/go_modules/all-go-mod-patch-and-minor-98ecf99d61
  • dependabot/go_modules/all-go-mod-patch-and-minor-a487f96682
  • dependabot/go_modules/all-go-mod-patch-and-minor-c2c31ec6fd
  • dependabot/go_modules/all-go-mod-patch-and-minor-cb2c6f47eb
  • dependabot/go_modules/all-go-mod-patch-and-minor-cb6672a63d
  • dependabot/go_modules/all-go-mod-patch-and-minor-d1390be7a8
  • dependabot/go_modules/all-go-mod-patch-and-minor-d3d652856c
  • dependabot/go_modules/all-go-mod-patch-and-minor-d67b2ec2dc
  • dependabot/go_modules/all-go-mod-patch-and-minor-ddbd8186df
  • dependabot/go_modules/all-go-mod-patch-and-minor-ddea56d916
  • dependabot/go_modules/all-go-mod-patch-and-minor-e06c7cabb1
  • dependabot/go_modules/all-go-mod-patch-and-minor-e12c8fdca3
  • dependabot/go_modules/all-go-mod-patch-and-minor-eb7b4d9acc
  • dependabot/go_modules/all-go-mod-patch-and-minor-edb6009c13
  • dependabot/go_modules/all-go-mod-patch-and-minor-f25765dcb0
  • dependabot/go_modules/all-go-mod-patch-and-minor-f99b886c21
  • dependabot/go_modules/all-go-mod-patch-and-minor-fed143a973
  • dependabot/go_modules/github.com/prometheus/client_golang-1.19.0
  • dependabot/go_modules/github.com/prometheus/client_golang-1.19.1
  • dependabot/go_modules/github.com/szuecs/routegroup-client-0.28.0
  • dependabot/go_modules/github.com/szuecs/routegroup-client-0.28.2
  • dependabot/go_modules/go_modules-bbb8b02913
  • dependabot/go_modules/go_modules-c153b83258
  • dependabot/go_modules/golang.org/x/net-0.23.0
  • dependabot/go_modules/golang.org/x/sync-0.7.0
  • dependabot/go_modules/google.golang.org/protobuf-1.33.0
  • dependabot/go_modules/k8s.io/client-go-0.28.8
  • dependabot/go_modules/k8s.io/client-go-0.30.0
  • dependabot/go_modules/k8s.io/client-go-0.30.1
  • dependabot/go_modules/k8s.io/code-generator-0.28.8
  • deprecated-linters
  • deps-1.27
  • drop-horizontalPodAutoscaler-field
  • drop-leftover-autoscaling-apis
  • e2e-deploy-sample
  • e2e-sample-for-reference
  • ensure-central-ingress
  • event-qps
  • external-rps-autoscaler
  • external-rps-hpa-reconcile
  • fix-autoscaling-test
  • fix-go-1-22-bug
  • fix-hpa
  • fix-kind-example
  • fix-logging
  • fix-panic
  • fix-predicate
  • fix-rps-scaling
  • fix-scaling-up-stacks-without-traffic
  • fix-tests
  • fix-typo
  • flaky-tests
  • generate-crd-rps-scaling
  • go-1.24
  • gomod
  • group-go-updates
  • hpa-metrics-order
  • hpa-to-segment
  • ingress-first
  • ingress-version
  • ingress-version-compare
  • inline-configmap-crd-support
  • internal-domains
  • internal-optional
  • kube-1.29
  • kubernetes-v1.23
  • kubernetes-v1.30.2
  • limit-reconcile-parallel
  • master
  • namespace-flag
  • only-internal
  • pcs-client
  • pcs-per-stack
  • pcs-per-stack-e2e
  • pcs-spec
  • pcs-status-types
  • per-stack-domain
  • pointer-optional
  • readme-update
  • reduce-e2e-scope
  • refactor-config
  • refs/tags/v1.4.100
  • refs/tags/v1.4.101
  • refs/tags/v1.4.102
  • refs/tags/v1.4.103
  • refs/tags/v1.4.104
  • refs/tags/v1.4.105
  • refs/tags/v1.4.106
  • refs/tags/v1.4.107
  • refs/tags/v1.4.108
  • refs/tags/v1.4.109
  • refs/tags/v1.4.110
  • refs/tags/v1.4.111
  • refs/tags/v1.4.112
  • refs/tags/v1.4.113
  • refs/tags/v1.4.114
  • refs/tags/v1.4.115
  • refs/tags/v1.4.116
  • refs/tags/v1.4.117
  • refs/tags/v1.4.118
  • refs/tags/v1.4.47
  • refs/tags/v1.4.48
  • refs/tags/v1.4.49
  • refs/tags/v1.4.50
  • refs/tags/v1.4.51
  • refs/tags/v1.4.52
  • refs/tags/v1.4.53
  • refs/tags/v1.4.54
  • refs/tags/v1.4.55
  • refs/tags/v1.4.56
  • refs/tags/v1.4.57
  • refs/tags/v1.4.58
  • refs/tags/v1.4.59
  • refs/tags/v1.4.60
  • refs/tags/v1.4.61
  • refs/tags/v1.4.62
  • refs/tags/v1.4.63
  • refs/tags/v1.4.64
  • refs/tags/v1.4.65
  • refs/tags/v1.4.66
  • refs/tags/v1.4.67
  • refs/tags/v1.4.68
  • refs/tags/v1.4.69
  • refs/tags/v1.4.70
  • refs/tags/v1.4.71
  • refs/tags/v1.4.72
  • refs/tags/v1.4.73
  • refs/tags/v1.4.74
  • refs/tags/v1.4.75
  • refs/tags/v1.4.76
  • refs/tags/v1.4.77
  • refs/tags/v1.4.78
  • refs/tags/v1.4.79
  • refs/tags/v1.4.80
  • refs/tags/v1.4.81
  • refs/tags/v1.4.82
  • refs/tags/v1.4.83
  • refs/tags/v1.4.84
  • refs/tags/v1.4.85
  • refs/tags/v1.4.86
  • refs/tags/v1.4.87
  • refs/tags/v1.4.88
  • refs/tags/v1.4.89
  • refs/tags/v1.4.90
  • refs/tags/v1.4.91
  • refs/tags/v1.4.92
  • refs/tags/v1.4.93
  • refs/tags/v1.4.94
  • refs/tags/v1.4.95
  • refs/tags/v1.4.96
  • refs/tags/v1.4.97
  • refs/tags/v1.4.98
  • refs/tags/v1.4.99
  • remove-central-ingress
  • remove-e2es
  • resource-templates-crd
  • resources-per-stack
  • revert-scaling-up-stacks-without-traffic
  • revised-adaptation
  • safer-flags
  • secret-per-stack
  • secret-per-stack-accessor
  • secret-per-stack-helpers
  • secret-per-stack-helpers-2
  • secret-per-stack-helpers-3
  • shorten-test-names
  • skipper-multiarch
  • stackset-crd-update
  • static-base-image
  • staticcheck
  • switch-traffic-before-100
  • sync-annotations
  • test-gap
  • test-refactoring
  • update-base-image
  • update-component-deps
  • update-dependencies
  • update-deps-2023-09
  • update-deps-2025-01-03
  • update-deps-24-02-13
  • update-deps-k8s-1.31
  • update-pcs-client
  • update-prescale-docs
  • update-readme
  • valid-app-id
  • with-delay

05 Sep 2023 06:50PM UTC coverage: 73.218% (+0.2%) from 72.992%
6088592617

Pull #365

github

mikkeloscar
Add the type match label

When using the `autoscaler` we are still letting `kube-metrics-adapter`
to rely in the metric name. This commit adds the `type` label to the
ZMON and SQS queue len metrics. It also sorts the metrics before
generating them, based on different criteria.

Previously, sort was based just on the HPA metric type. Now sort is done
by `StackSet`'s `autoscaler` metric type and once it conflicts
`Average`, `AverageUtilization`, etc. It guarantees we support multiple
metrics of the same type and do not regenerate the HPA if Kubernetes
sends the metrics in a different order.

Co-authored-by: Katyanna Moura <amelie.kn@gmail.com>
Signed-off-by: Jonathan Juares Beber <jonathanbeber@gmail.com>
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
Pull Request #365: Add the type match label

67 of 67 new or added lines in 2 files covered. (100.0%)

2250 of 3073 relevant lines covered (73.22%)

0.82 hits per line

Relevant lines Covered
Build:
Build:
3073 RELEVANT LINES 2250 COVERED LINES
0.82 HITS PER LINE
Source Files on type-label
  • Tree
  • List 15
  • Changed 3
  • Source Changed 0
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
6088592617 type-label Add the type match label When using the `autoscaler` we are still letting `kube-metrics-adapter` to rely in the metric name. This commit adds the `type` label to the ZMON and SQS queue len metrics. It also sorts the metrics before generating them... Pull #365 05 Sep 2023 06:54PM UTC mikkeloscar github
73.22
6088548885 type-label Add the type match label When using the `autoscaler` we are still letting `kube-metrics-adapter` to rely in the metric name. This commit adds the `type` label to the ZMON and SQS queue len metrics. It also sorts the metrics before generating them... Pull #365 05 Sep 2023 06:49PM UTC mikkeloscar github
73.26
6088424194 type-label Add the type match label When using the `autoscaler` we are still letting `kube-metrics-adapter` to rely in the metric name. This commit adds the `type` label to the ZMON and SQS queue len metrics. It also sorts the metrics before generating them... Pull #365 05 Sep 2023 06:35PM UTC mikkeloscar github
73.24
1517251279 type-label Add the type match label push 29 Nov 2021 06:05PM UTC Jonathan Juares Beber github
74.41
1517251448 type-label Add the type match label Pull #365 29 Nov 2021 06:04PM UTC Jonathan Juares Beber github
74.41
1517234171 type-label Add the type match label push 29 Nov 2021 06:00PM UTC Jonathan Juares Beber github
74.35
1517230419 type-label Add the type match label Pull #365 29 Nov 2021 06:00PM UTC Jonathan Juares Beber github
74.41
1517235209 type-label Add the type match label push 29 Nov 2021 06:00PM UTC Jonathan Juares Beber github
74.41
1517235271 type-label Add the type match label Pull #365 29 Nov 2021 06:00PM UTC Jonathan Juares Beber github
74.41
1517234354 type-label Add the type match label Pull #365 29 Nov 2021 06:00PM UTC Jonathan Juares Beber github
74.41
See All Builds (3111)
  • Repo on GitHub
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc