zalando-incubator / stackset-controller / 6088548885

73%

master: 56%

Pull #365

github

Add the type match label

When using the `autoscaler` we are still letting `kube-metrics-adapter`
to rely in the metric name. This commit adds the `type` label to the
ZMON and SQS queue len metrics. It also sorts the metrics before
generating them, based on different criteria.

Previously, sort was based just on the HPA metric type. Now sort is done
by `StackSet`'s `autoscaler` metric type and once it conflicts
`Average`, `AverageUtilization`, etc. It guarantees we support multiple
metrics of the same type and do not regenerate the HPA if Kubernetes
sends the metrics in a different order.

Co-authored-by: Katyanna Moura <amelie.kn@gmail.com>
Signed-off-by: Jonathan Juares Beber <jonathanbeber@gmail.com>
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>

64 of 64 new or added lines in 2 files covered. (100.0%)

2249 of 3070 relevant lines covered (73.26%)

0.82 hits per line