yast / yast-packager
37%
master: 37%

LAST BUILD BRANCH: solv-compatibility-error-m
DEFAULT BRANCH: master
Repo Added
Files 90
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH SLE-15-SP6
branch: SLE-15-SP6
CHANGE BRANCH
x

coverage: 37.466% (+0.02%) from 37.444%
16317721241

push

github

web-flow 
Merge pull request #660 from yast/solv-compatibility-error

## Problem

When selecting SLE-HA as add-on product, either during installation or via "yast2 add-on", an Internal Error pops up as soon as one clicks that product.

It is a combination of two factors:
1. the product description (coming from the Description field of `sle-ha-release.rpm`) is in English but it contains a non-ASCII character (a curly apostrophe)
2. YaST retrieves that string via `ruby-solv.rpm`, a Swig binding of `libsolv`, which returns ALL strings marked with `Encoding::ASCII_8BIT`, which means `BINARY`

When trying to combine two strings, one `UTF_8` and the other `ASCII_8BIT`, `Encoding::CompatibilityError` is raised, *unless* one of the strings happens to contain pure ASCII, which is why htis problem went undetected for so long.

- https://bugzilla.suse.com/show_bug.cgi?id=1245555 (L3)
- https://trello.com/c/cRMoDGxs

## Solution

For the solvable fields likely to contain non-ASCII text, Summary and Description, call `String#force_encoding` on the value retrieved from libsolv

## Testing

Tested manually

1. running as root "yast2 add-on" on my Leap 15.6
2. Add... Url: http://download.suse.de/install/SLP/SLE-15-SP7-Full-PublicRC-202504/x86_64/DVD1/ ... Next
3. Click the "SUSE Linux ... High Availability ..." line
4. the Internal Error happens (or doesn't, with the fix)


## Screenshots

No

4 of 4 new or added lines in 1 file covered. (100.0%)

4346 of 11600 relevant lines covered (37.47%)

23.66 hits per line

Relevant lines Covered
11600 RELEVANT LINES 4346 COVERED LINES
23.66 HITS PER LINE
Source Files on SLE-15-SP6

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
16317721241 SLE-15-SP6 Merge pull request #660 from yast/solv-compatibility-error ## Problem When selecting SLE-HA as add-on product, either during installation or via "yast2 add-on", an Internal Error pops up as soon as one clicks that product. It is a combination o... push web-flow github
37.47
8267851543 SLE-15-SP6 Merge pull request #656 from yast/hpc_sp6 push web-flow github
37.44
8005295483 SLE-15-SP6 Merge pull request #652 from yast/better_summary_sp6 push web-flow github
37.38
7898530346 SLE-15-SP6 Merge pull request #650 from yast/slehpc_sp6 push web-flow github
37.38
7868979035 SLE-15-SP6 Merge pull request #648 from yast/fix_erb_loading_sp6 push web-flow github
37.38
7463490418 SLE-15-SP6 Merge pull request #645 from yast/disable_online_dvd_sp6 Disable online dvd sp6 push web-flow github
37.39
6250068267 SLE-15-SP6 Merge pull request #642 from yast/service_fix_sp6 [SLE-15-SP6] Properly save the repo file (bsc#1214135) push web-flow github
37.38
6184951647 SLE-15-SP6 Merge pull request #641 from yast/backport_sp6 Backport sp6 push web-flow github
37.39
See All Builds (2398)