yast / yast-packager / 16317721241

37%

master: 37%

push

github

Merge pull request #660 from yast/solv-compatibility-error

## Problem

When selecting SLE-HA as add-on product, either during installation or via "yast2 add-on", an Internal Error pops up as soon as one clicks that product.

It is a combination of two factors:
1. the product description (coming from the Description field of `sle-ha-release.rpm`) is in English but it contains a non-ASCII character (a curly apostrophe)
2. YaST retrieves that string via `ruby-solv.rpm`, a Swig binding of `libsolv`, which returns ALL strings marked with `Encoding::ASCII_8BIT`, which means `BINARY`

When trying to combine two strings, one `UTF_8` and the other `ASCII_8BIT`, `Encoding::CompatibilityError` is raised, *unless* one of the strings happens to contain pure ASCII, which is why htis problem went undetected for so long.

- https://bugzilla.suse.com/show_bug.cgi?id=1245555 (L3)
- https://trello.com/c/cRMoDGxs

## Solution

For the solvable fields likely to contain non-ASCII text, Summary and Description, call `String#force_encoding` on the value retrieved from libsolv

## Testing

Tested manually

1. running as root "yast2 add-on" on my Leap 15.6
2. Add... Url: http://download.suse.de/install/SLP/SLE-15-SP7-Full-PublicRC-202504/x86_64/DVD1/ ... Next
3. Click the "SUSE Linux ... High Availability ..." line
4. the Internal Error happens (or doesn't, with the fix)


## Screenshots

No

4 of 4 new or added lines in 1 file covered. (100.0%)

4346 of 11600 relevant lines covered (37.47%)

23.66 hits per line