xapi-project / stdext

99%

master: 99%

LAST BUILD ON BRANCH CA-310525

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• master
• v4.1.0
• v4.2.0
• v4.3.0
• v4.4.0
• v4.4.1

Build # 62

Build Type

Pull #36

travis-ci

Committed by web-flow

Commit Message

CA-310525 fix C binding for statvfs

We rarely see statvfs return 0 for bfree and suspect that this is a GC
related problem. The existing implementation violates rule 6 in the
OCaml manual

  https://caml.inria.fr/pub/docs/manual-ocaml/intfc.html#sec442

which mandates to use caml_modify when updating a field with an existing
value. This commit handles this by using Store_field. See also the
discussion at

  https://discuss.ocaml.org/t/finding-gc-problems-in-c-bindings/3453/2

Signed-off-by: Christian Lindig <christian.lindig@citrix.com>

Pull Request Pull Request #36: CA-310525 fix C binding for statvfs

Run Details

73 of 74 relevant lines covered (98.65%)

2001792.78 hits per line