wooga / github-changelog-lib

93%

master: 91%

LAST BUILD ON BRANCH PR-5

branch: PR-5

CHANGE BRANCH

x

Reset

• PR-5
• PR-1
• PR-13
• PR-14
• PR-16
• PR-2
• PR-26
• PR-29
• PR-30
• PR-31
• PR-32
• PR-33
• PR-34
• PR-35
• PR-36
• PR-37
• PR-38
• PR-39
• PR-4
• PR-40
• PR-42
• PR-43
• PR-44
• PR-45
• PR-46
• PR-47
• PR-48
• PR-49
• PR-50
• PR-52
• PR-54
• PR-57
• PR-6
• PR-61
• PR-7
• fix/release_date_format
• main
• master

Improve commit range validation

Description
===========

It is possible to provide a valid tag name or commit sha as _from_ and
_to_ parameters. The resulting commits are checked if they are available
but not if they are reachable from the provided branch.

```
NR
9         * commit 4 on develop
8         * commit 3 on develop
7       * | commit 5 (tag: v0.1.1)
6       * | commit 4
5       | * commit 2 on develop
4       * | commit 3 (tag: v0.1.0)
3       | * commit 1 on develop
        |/
2       * commit 2
1       * Initial commit
```

One could call `changeDetector.detectChangesFromTag('v0.1.0`, 'v0.1.1', 'develop')`
or with the commit SHA's and the function would fail with an generic
`java.lang.IllegalArgumentException`. This patch adds a range check for
the provided parameters and throws a more meaningfill exception.

Changes
=======

* ![IMPROVE] range validation for provided from/to parameters