• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

wooga / github-changelog-lib / 5
93%
master: 91%

Build:
Build:
LAST BUILD BRANCH: PR-61
DEFAULT BRANCH: master
Ran 29 May 2020 11:59AM UTC
Jobs 3
Files 11
Run time 27s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
5

push

jenkins

Improve commit range validation

Description
===========

It is possible to provide a valid tag name or commit sha as _from_ and
_to_ parameters. The resulting commits are checked if they are available
but not if they are reachable from the provided branch.

```
NR
9         * commit 4 on develop
8         * commit 3 on develop
7       * | commit 5 (tag: v0.1.1)
6       * | commit 4
5       | * commit 2 on develop
4       * | commit 3 (tag: v0.1.0)
3       | * commit 1 on develop
        |/
2       * commit 2
1       * Initial commit
```

One could call `changeDetector.detectChangesFromTag('v0.1.0`, 'v0.1.1', 'develop')`
or with the commit SHA's and the function would fail with an generic
`java.lang.IllegalArgumentException`. This patch adds a range check for
the provided parameters and throws a more meaningfill exception.

Changes
=======

* ![IMPROVE] range validation for provided from/to parameters

222 of 246 relevant lines covered (90.24%)

2.71 hits per line

Jobs
ID Job ID Ran Files Coverage
1 5.1 29 May 2020 11:59AM UTC 0
90.24
2 5.2 29 May 2020 12:00PM UTC 0
90.24
3 5.3 29 May 2020 12:00PM UTC 0
90.24
Source Files on build 5
Detailed source file information is not available for this build.
  • Back to Repo
  • Jenkins Build #5
  • df322586 on github
  • Prev Build on PR-5 (#4)
  • Next Build on PR-5 (#6)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc