wheniwork / oauth2-square
100%

Repo Added 06 Mar 2015 09:16PM UTC

Files 3

Badge

Embed ▾

LAST BUILD ON BRANCH master
branch: SELECT

CHANGE BRANCH
x

No branch selected

dev

feature/get-url-public

hotfix/http-build-query-sort

master

v1.2.1

v1.2.2

v1.2.3

v1.2.4

v1.3.0

v2.0.0-beta1

pending completion

Build # 50

Build Type

Pull #2

travis-ci

Committed by

web-flow

Commit Message

Override AbstractProvider->httpBuildQuery() in Square provider

Square appears to perform a superfluous redirect during the OAuth
workflow that does two things: 1) sorts query string parameters; 2)
removes an approval_prompt parameter automatically added by
AbstractProvider->getAuthorizationUrl().

At best, this adds a needless request to the OAuth workflow, making it
take longer. It appears that it may also be causing the workflow to fail
in Square->prepareAccessTokenResult() within a local development environment.

Pull Request Pull Request #2: Override AbstractProvider->httpBuildQuery() in Square provider

Run Details

3 of 3 new or added lines in 1 file covered. (100.0%)

64 of 64 relevant lines covered (100.0%)

1.98 hits per line

Relevant lines Covered

64 RELEVANT LINES 64 COVERED LINES

1.98 HITS PER LINE

Source Files on master

Detailed source file information is not available for this build.

Recent builds

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
50	master	Override AbstractProvider->httpBuildQuery() in Square provider Square appears to perform a superfluous redirect during the OAuth workflow that does two things: 1) sorts query string parameters; 2) removes an approval_prompt parameter automaticall...	Pull #2	16 Jan 2018 05:16PM UTC	web-flow	travis-ci	pending completion
49	hotfix/http-build-query-sort	Override AbstractProvider->httpBuildQuery() in Square provider Square appears to perform a superfluous redirect during the OAuth workflow that does two things: 1) sorts query string parameters; 2) removes an approval_prompt parameter automaticall...	push	16 Jan 2018 05:10PM UTC	elazar	travis-ci	pending completion
48	v1.3.0	Make getConnectUrl public (#1)	push	13 Apr 2016 03:53PM UTC	ameech	travis-ci	pending completion
47	master	Make getConnectUrl public (#1)	push	13 Apr 2016 03:50PM UTC	ameech	travis-ci	pending completion
46	master	Make getConnectUrl public	Pull #1	13 Apr 2016 03:45PM UTC	ameech	travis-ci	pending completion
45	feature/get-url-public	Make getConnectUrl public	push	13 Apr 2016 03:45PM UTC	ameech	travis-ci	pending completion
44	dev	Allow HHVM build failures Caused by mocked exceptions, not going to worry about it right now.	push	05 Aug 2015 05:58PM UTC	shadowhand	travis-ci	pending completion
43	v2.0.0-beta1	Upgrade to oauth client 1.0 - drop PHP 5.4 support - match new interfaces - fix tests - update docs	push	05 Aug 2015 05:53PM UTC	shadowhand	travis-ci	pending completion
42	dev	Upgrade to oauth client 1.0 - drop PHP 5.4 support - match new interfaces - fix tests - update docs	push	05 Aug 2015 05:53PM UTC	shadowhand	travis-ci	pending completion
41	dev	Update documentation	push	05 Aug 2015 05:52PM UTC	shadowhand	travis-ci	pending completion

See All Builds (29)

wheniwork / oauth2-square
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst