vuepress / core

74%

LAST BUILD ON BRANCH main

branch: main

CHANGE BRANCH

x

Reset

Sync Branches

• main
• 1277-code-block-title
• absolutePathPrependBase
• as-needed
• auto-link
• auto-link-improvement
• auto-link-test
• bundler-helper
• bundler-refine
• chokidar
• ci
• client
• client-data
• client-file
• client-perf
• client-type
• client-types
• codePlugin
• codeql
• config-file
• configure-vite
• copilot/add-devserver-cleanup-hook
• copilot/fix-fs-watch-issues
• copilot/fix-onpageupdated-racing-condition
• dependabot/npm_and_yarn/vite-5.0.12
• deps
• devtools
• drop-node-20
• engine
• export
• extension
• feat/farm-bundler
• feat/re-export-vite-client-types
• fix-1715
• fix-chokidar-v4
• fix-siteData-locales
• fix/bundler-webpack-ssr-externals
• fix/client-ssr-content-updated
• fix/hash-scroll-margin-top
• fix/remove-compromised-issues-helper
• fix/vuepress-node-env
• header
• ignore
• isLinkExternal
• isLinkWithProtocol
• locales
• markdown-links
• markdown/tweaks
• meteorlxy-markdown-to-vue
• meteorlxy/client-data-aliases
• meteorlxy/content-updated-set
• meteorlxy/css-modules
• meteorlxy/deps
• meteorlxy/drop-node-18
• meteorlxy/fix-permalink
• meteorlxy/playwright
• meteorlxy/playwright-update
• meteorlxy/refactor-cli
• meteorlxy/refactor-patterns
• meteorlxy/replace-globby
• meteorlxy/upgrade-chokidar
• meteorlxy/vite-7
• migrate-tsdown
• mismatch
• navigation
• new-router
• normalizeRoutePath
• on-content-updated
• oxfmt
• page-patterns
• page-update-params
• page-update-racing
• page-watcher
• path-fix
• permalink
• pnpm-ci
• pnpm10
• query-and-hash
• redirect
• refactor
• refs/pull/1537/merge
• refs/pull/1545/merge
• refs/pull/1546/merge
• refs/pull/1556/merge
• refs/pull/1562/merge
• refs/pull/1564/merge
• refs/pull/1716/merge
• resolve-route
• resolveRoutePathFromUrl
• rolldown
• route-link
• route-option
• route-relative
• router
• router-types
• rspack
• sanitizeFileName
• sass
• shared-test
• short-client-data
• siteLocaleData
• template-outlets
• test
• tweaks
• upgrade-eslint
• user-style
• user-style-improvement
• vite-alias
• vite-fix
• vplink
• vplink-fix
• vuepress-tweaks
• watch-page-files
• webpack-chain
• webpack-fix
• webpack-noparse
• webpack-target
• webpack-tweaks
• webpack-types
• write-temp

Build # 36579630257

Build Type

push

github

Committed by web-flow

Commit Message

fix(bundler-webpack): externalize vue subpaths in ssr bundle (close #1718) (#1725)

The server bundle only externalized `vue` itself. The array form of
webpack `externals` matches requests exactly, so `vue/server-renderer`,
which SFCs compiled for SSR import from, was resolved to
`@vue/server-renderer` and bundled together with its own copies of
`@vue/runtime-core` and `@vue/shared`, while `vue` stayed external.

With two vue runtimes in one server bundle, components are created by
the bundled runtime, and `instance.refs` is the bundled `EMPTY_OBJ`,
but `useTemplateRef` comes from the external `vue` and compares it with
its own `EMPTY_OBJ`. With the production build of vue, the check never
matches, so the ref is defined as a non-configurable property on the
shared `EMPTY_OBJ`, and rendering another page that uses the same ref
key throws `Cannot redefine property`, leaving the page content empty
in the generated HTML.

Externalize `vue` and all of its subpaths. `@vue/*` packages are not
externalized, because they are not guaranteed to be resolvable from the
temp directory with pnpm, e.g. `@vue/devtools-api`.

Coverage Stats

412 of 552 branches covered (74.64%)

Branch coverage included in aggregate %.

800 of 1087 relevant lines covered (73.6%)

48.34 hits per line